Reduce file existence checks when servicing directory exists #123568
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the presence of a servicing directory would enable file existence checks for all probed files (app, framework, lookup, and servicing directories). This change limits file existence checks to only when probing the servicing directory itself. This reduces I/O operations during startup for applications that have a servicing directory present but don't use additional probe paths or shared stores.
Contributor
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces hostpolicy startup I/O when a servicing directory exists by limiting file existence checks to servicing probes instead of enabling them globally.
Changes:
- Stop setting the global
m_needs_file_existence_checksflag solely due to the presence of the servicing directory. - When probing a servicing config, explicitly enable
is_servicing+file_existencesearch options for that probe only.
jkoritzinsky
approved these changes
Jan 23, 2026
This was referenced Jan 24, 2026
Open
AaronRobinsonMSFT
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of a servicing directory (even empty) would enable file existence checks for all files in the deps.json. We always look in the servicing directory first (if it exists) - and only care about the file existence there, not in the regular app directory. This change limits file existence checks to only when probing the servicing directory itself.
This reduces I/O operations during startup for applications that have a servicing directory present (and don't use additional probe paths or shared stores).
For the staticconsoletemplate startup test in dotnet/performance, running locally on Windows, if an empty servicing directory exists:
@dotnet/appmodel @AaronRobinsonMSFT